[hipblaslt] tensilelite client validation threshold fix for tf32x3 and tf32x1#4890
Merged
carsonbrownlee merged 4 commits intodevelopfrom Feb 27, 2026
Merged
Conversation
github-actions
bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
carsonbrownlee
changed the title
perfci run on commit 49fe485 |
perfci run on commit 4cad8a2 |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (76.83%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #4890 +/- ##
========================================
Coverage 65.96% 65.96%
========================================
Files 1720 1720
Lines 267465 267465
Branches 37091 37091
========================================
Hits 176427 176427
Misses 75473 75473
Partials 15565 15565
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
carsonbrownlee
force-pushed
the
users/cbrownle/tf32_accuracyfix
branch
from
dade002 to
1eab8ec
Compare
perfci run on commit 891ff74 |
msujon-AMD
reviewed
Feb 26, 2026
msujon-AMD
approved these changes
Feb 26, 2026
Collaborator
|
BTW, we may not need K in threshold for RND_INT initialization since we may not have any precision loss in down-conversion. I am not sure if we consider that as a special case. |
assistant-librarian bot
pushed a commit
to ROCm/hipBLASLt
that referenced
this pull request
Feb 27, 2026
[hipblaslt] tensilelite client validation threshold fix for tf32x3 and tf32x1 (#4890) ## Motivation enable trig_init comparisons for tensilelite for tf32x3 and tf32x1. ## Technical Details Modify hardcoded thresholds in tensilelite validation to vary based on sqrt(k). Currently only implemented for float comparison for tf32x3 and tf32x1. ## Test Plan Tested with tensilelite yamls, modifying Tensile/Tests/common/gemm/gfx950/xfp32.yaml and ss_bss.yaml to have datainittypeA/B: 12/13. Only xfp32.yaml (tf32x3) test modified to use trig init as it makes more sense to test the lower bits by default. ss_bss.yaml not changed and needs to be modified to test. ## Test Result PASS
kokolchin
pushed a commit
to kokolchin/rocm-libraries
that referenced
this pull request
Mar 4, 2026
…d tf32x1 (ROCm#4890) ## Motivation enable trig_init comparisons for tensilelite for tf32x3 and tf32x1. ## Technical Details Modify hardcoded thresholds in tensilelite validation to vary based on sqrt(k). Currently only implemented for float comparison for tf32x3 and tf32x1. ## Test Plan Tested with tensilelite yamls, modifying Tensile/Tests/common/gemm/gfx950/xfp32.yaml and ss_bss.yaml to have datainittypeA/B: 12/13. Only xfp32.yaml (tf32x3) test modified to use trig init as it makes more sense to test the lower bits by default. ss_bss.yaml not changed and needs to be modified to test. ## Test Result PASS
NaveenElumalaiAMD
pushed a commit
that referenced
this pull request
Mar 6, 2026
…d tf32x1 (#4890) ## Motivation enable trig_init comparisons for tensilelite for tf32x3 and tf32x1. ## Technical Details Modify hardcoded thresholds in tensilelite validation to vary based on sqrt(k). Currently only implemented for float comparison for tf32x3 and tf32x1. ## Test Plan Tested with tensilelite yamls, modifying Tensile/Tests/common/gemm/gfx950/xfp32.yaml and ss_bss.yaml to have datainittypeA/B: 12/13. Only xfp32.yaml (tf32x3) test modified to use trig init as it makes more sense to test the lower bits by default. ss_bss.yaml not changed and needs to be modified to test. ## Test Result PASS
jovanau
pushed a commit
to jovanau/rocm-libraries
that referenced
this pull request
Mar 19, 2026
…d tf32x1 (ROCm#4890) ## Motivation enable trig_init comparisons for tensilelite for tf32x3 and tf32x1. ## Technical Details Modify hardcoded thresholds in tensilelite validation to vary based on sqrt(k). Currently only implemented for float comparison for tf32x3 and tf32x1. ## Test Plan Tested with tensilelite yamls, modifying Tensile/Tests/common/gemm/gfx950/xfp32.yaml and ss_bss.yaml to have datainittypeA/B: 12/13. Only xfp32.yaml (tf32x3) test modified to use trig init as it makes more sense to test the lower bits by default. ss_bss.yaml not changed and needs to be modified to test. ## Test Result PASS
johannes-graner
pushed a commit
that referenced
this pull request
Mar 20, 2026
…d tf32x1 (#4890) ## Motivation enable trig_init comparisons for tensilelite for tf32x3 and tf32x1. ## Technical Details Modify hardcoded thresholds in tensilelite validation to vary based on sqrt(k). Currently only implemented for float comparison for tf32x3 and tf32x1. ## Test Plan Tested with tensilelite yamls, modifying Tensile/Tests/common/gemm/gfx950/xfp32.yaml and ss_bss.yaml to have datainittypeA/B: 12/13. Only xfp32.yaml (tf32x3) test modified to use trig init as it makes more sense to test the lower bits by default. ss_bss.yaml not changed and needs to be modified to test. ## Test Result PASS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
enable trig_init comparisons for tensilelite for tf32x3 and tf32x1.
Technical Details
Modify hardcoded thresholds in tensilelite validation to vary based on sqrt(k). Currently only implemented for float comparison for tf32x3 and tf32x1.
Test Plan
Tested with tensilelite yamls, modifying Tensile/Tests/common/gemm/gfx950/xfp32.yaml and ss_bss.yaml to have datainittypeA/B: 12/13. Only xfp32.yaml (tf32x3) test modified to use trig init as it makes more sense to test the lower bits by default. ss_bss.yaml not changed and needs to be modified to test.
Test Result
PASS